This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Patch to bfd/aix5ppc-core.c for gdb-6.3 with gcc 4 on AIX5.1
- From: Nick Clifton <nickc at redhat dot com>
- To: Rodney Brown <rbrown at bravurasolutions dot com dot au>
- Cc: gdb-patches at sources dot redhat dot com, binutils at sources dot redhat dot com
- Date: Tue, 02 Aug 2005 12:04:56 +0100
- Subject: Re: Patch to bfd/aix5ppc-core.c for gdb-6.3 with gcc 4 on AIX5.1
- References: <4F3B985B8E683C45B8C5F76B7AAB5AE5215F70@EXCHANGE.bravurasolutions.local>
Hi Rodney,
powerpc-ibm-aix5.1.0.0 gcc version 4.0.1
../../gdb-6.3/bfd/aix5ppc-core.c: In function 'xcoff64_core_p':
../../gdb-6.3/bfd/aix5ppc-core.c:120: error: invalid lvalue in
assignment
I am unable to reproduce this failure :-(
2005-07-12 Rodney Brown <rbrown@bravurasolutions.com.au>
* aix5ppc-core.c (core_hdr): #define as LHS varient.
(xcoff64_core_p): Constify return_value variable.
I am hesitant to apply a patch which does not appear to be needed.
-#define core_hdr(abfd) ((struct core_dumpxx *)
abfd->tdata.any)
+#define core_hdr(abfd) (abfd->tdata.any) /* gcc 4
support */
Is this necessary. You could just alter the use of core_hdr() in
xcoff64_core_p() and leave the macro alone.
Cheers
Nick