This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] x86: adjust relocation overflow complaint types

Andreas Schwab <schwab@suse.de> writes:

> Ian Lance Taylor <ian@airs.com> writes:
> 
> > For what it's worth, I agree with Michael.  R_386_PC16 reliably wraps
> > around in 16-bit code.
> 
> But then it shouldn't be represented internally as BFD_RELOC_16_PCREL,
> since that has different semantics.

I think that by that argument we also shouldn't use BFD_RELOC_32_PCREL
for the 32-bit PC relative relocation, because it also doesn't use
complain_overflow_signed.

I'm not actually sure the internal reloc number used by BFD makes any
difference, but if it does, then perhaps it should indeed be changed.

Ian
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]