This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] x86: fix assembler's @got-style relocation handling
- From: "H. J. Lu" <hjl at lucon dot org>
- To: Jan Beulich <JBeulich at novell dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Wed, 13 Jul 2005 13:28:06 -0700
- Subject: Re: [PATCH] x86: fix assembler's @got-style relocation handling
- References: <s2c9f386.049@lucius.provo.novell.com>
On Tue, Jul 05, 2005 at 02:42:48AM -0600, Jan Beulich wrote:
> >>> "H. J. Lu" <hjl@lucon.org> 16.06.05 16:52:59 >>>
> >On Thu, Jun 16, 2005 at 08:43:11AM -0600, Jan Beulich wrote:
> >> ---
> /home/jbeulich/src/binutils/mainline/2005-06-16/gas/config/tc-i386.c 2005-06-08
> 14:50:49.000000000 +0200
> >> +++ 2005-06-16/gas/config/tc-i386.c 2005-06-16 16:01:18.006910784
> +0200
> >> @@ -1201,22 +1201,54 @@ pt (t)
> >> #endif /* DEBUG386 */
> >>
> >> static bfd_reloc_code_real_type reloc
> >> - PARAMS ((int, int, int, bfd_reloc_code_real_type));
> >> + PARAMS ((unsigned int, int, int, bfd_reloc_code_real_type));
> >>
> >> static bfd_reloc_code_real_type
> >> reloc (size, pcrel, sign, other)
> >> - int size;
> >> + unsigned int size;
> >> int pcrel;
> >> int sign;
> >> bfd_reloc_code_real_type other;
> >
> >Could you please change those functions to C90 while you are on it?
>
> Done, also for lex_got.
>
OK. Thanks.
H.J.