This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] x86: fix assembler's @got-style relocation handling
- From: "H. J. Lu" <hjl at lucon dot org>
- To: Jan Beulich <JBeulich at novell dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Thu, 16 Jun 2005 08:06:40 -0700
- Subject: Re: [PATCH] x86: fix assembler's @got-style relocation handling
- References: <s2b13f69.019@lyle.provo.novell.com>
On Thu, Jun 16, 2005 at 08:59:23AM -0600, Jan Beulich wrote:
> >Could you please change those functions to C90 while you are on it?
>
> Wouldn't it make more sense to do this for the whole file, and as a separate checkin?
>
Since you have to change those function prototypes anyway, I don't
feel we should add more K&R stuff.
H.J.