This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATH: Restore file cache for bfd_openr

On Wed, Jun 08, 2005 at 09:48:49PM -0700, Mark Mitchell wrote:
> Alan Modra wrote:
> >On Wed, Jun 08, 2005 at 03:43:21PM -0700, Mark Mitchell wrote:
> >
> >>	* opncls.c (bfd_openr): Call bfd_set_cacheable on returned BFDs. 
> >
> >
> >I think it makes sense to do this in bfd_fopen instead, if fd != -1.
> >ie. Make your new bfd_fopen function default to the auto-close/open
> >behaviour.  Thoughts?
> 
> Makes sense to me.  May I check in that variation, assuming the same 
> testing shows that it works OK?

Yes.  And I meant if fd == -1, of course.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]