This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ia64: fix regression from fix for PR/803


On Mon, 2005-05-23 at 06:54, Jan Beulich wrote:
> I additionallly wonder whether M-unit NOPs shouldn't be preferred over I-
> unit ones (by letting extra_goodness return 2 only for an M-unit match, but
> 1 for an I-unit match).

We will get a lot more M nops this way, but that is probably a good
thing since we have 4 M issue slots and only 2 I issue slots.  I suspect
this would result in more dual issued bundles.  Hard to say without
doing an experiment though.

> 	* config/tc-ia64.c (md_begin): Don't try to match slot 2 of an MLX
> 	template.

OK.

While looking at this, I noticed that the comment before extra_goodness
is out-of-date.  HJ forgot to update it when he changed the code.  Also,
I wanted to double check that the result was OK, so I added some
debugging code to print out the best_template array, so I could make
sure it was OK after this change.  I've attached the patch I wrote for
this.  I plan to check this in after you check in your patch.
-- 
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com

Attachment: patch.extra.goodness
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]