This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Linker is broken due to _bfd_elf_merge_symbol change

On Wed, May 04, 2005 at 06:10:02AM -0700, H. J. Lu wrote:
> On Wed, May 04, 2005 at 02:08:03PM +0100, Paul Brook wrote:
> > > +  /* Skip weak definitions of symbols that are already defined.  */
> > > +  if (newdef && olddef && newweak && !oldweak)
> > > +    *skip = TRUE;
> > 
> > Shouldn't this also return TRUE?
> 
> Not if flip != NULL.

Actually, the two conditions are mutually exclusive.  Since the flip
block is the last one in the function, I don't think it matters one way
or another.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]