This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Fixup references to bfd_section_list... macros
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Tue, 3 May 2005 22:14:43 +0930
- Subject: Re: Fixup references to bfd_section_list... macros
- References: <m3ll6wmsbh.fsf@redhat.com>
On Tue, May 03, 2005 at 01:01:38PM +0100, Nick Clifton wrote:
> Hi Guys,
>
> H.J.'s recent patch to update the bfd_section_list manipulation
> macros fixed a few small cases in the gas directory. So I am going
> to apply the patch below to fix them.
They aren't the only breakage. Grrr.
> * config/obj-ecoff.c (ecoff_frob_file_before_fix): Fix invocations
> of bfd_section_list... macros.
Um, this is still broken. sec->next is trashed by HJ's
bfd_section_list_remove.
> * config/tc-mmix.c (mmix_frob_file): Likewise.
And this isn't ideal. No need to traverse the list.
> * config/tc-xtensa.c (xtensa_remove_section): Likewise.
Same here.
> (xtensa_insert_section): Likewise.
And this is still broken. You aren't having a good day. :)
I was in the middle of testing fixes for all these, plus some others in
bfd/. Expect a commit sometime soon after I rerun the tests. (My first
bash at fixing them wasn't too hot either..)
--
Alan Modra
IBM OzLabs - Linux Technology Centre