This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] x86-64: certain pcrel expressions broken
- From: "Jan Beulich" <JBeulich at novell dot com>
- To: <drow at false dot org>
- Cc: <hjl at lucon dot org>,<binutils at sources dot redhat dot com>, <aj at suse dot de>
- Date: Mon, 11 Apr 2005 10:02:26 +0200
- Subject: Re: [PATCH] x86-64: certain pcrel expressions broken
I would obviously check in an adjusted patch accounting for the fundamental problem H.J. had found (and fixed) with it. Awaiting your agreement... Jan
>>> Daniel Jacobowitz <drow@false.org> 04.04.05 15:42:06 >>>
On Mon, Apr 04, 2005 at 12:44:53PM +0200, Andreas Jaeger wrote:
> "Jan Beulich" <JBeulich@novell.com> writes:
>
> > Should this also go in the 2.16 branch?
>
> This is something the release manager has to approve,
This looks appropriate to me; please do.
>
> Andreas
>
> >>>> Andreas Jaeger <aj@suse.de> 31.03.05 21:51:56 >>>
> > "Jan Beulich" < JBeulich@novell.com > writes:
> >
> >>>>> Andreas Jaeger < aj@suse.de > 29.03.05 21:53:12 >>>
> >>>"Jan Beulich" < JBeulich@novell.com > writes:
> >>>
> >>>> While expressions like "sym - ." were correctly converted to use pc-relative
> >>>> relocations for 8-, 16-, and 32-bit operations, sign-extended 32-bit operands
> >>>> of 64-bit operations didn't get converted.
> >>>
> >>>Do you have a testcase?
> >>
> >> Attached/below.
> >>
> >> Built and tested on x86_64-unknown-linux-gnu.
> >
> > This patch is approved,
> >
> > thanks,
> > Andreas
> >
> >
> >
>
> Andreas
> --
> Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
--
Daniel Jacobowitz
CodeSourcery, LLC