Re: [PATCH-RFC] Testcase(s) for VAX' new -M entry:0xf00 feature

[Nick Clifton <nickc at redhat dot com>]

Hi Jan-Benedict,

  I have checked your new VAX test patch into the CVS repository.


> > +.type label2,@function
> > +label2:
>
> I've built this for vax-netbsd and vax-netbsdelf. The ELF variant
> works as expected, but vax-netbsd (a.out) seems to ignore the
> ".type label2,@function" 

Yes - the .type directive is not supported by the a.out format.

> and thus objdump -d won't disassemble
> label2 as a function.
>
> I'd modify the test in two ways, which one do you think is preferrable:
>
> - Exclude non-ELF targets from the test (how do I do that?)

See the proc is_elf_format defined in 
binutils/testsuite/lib/utils-lib.exp and used for example in 
binutils-all/readelf.exp.

> - Also add a -M entry:0x... for label2 (which I'd prefer to do)

I think that I would prefer this approach as well.

Cheers
  Nick