This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Patch: binutils/rename.c -Werror fixes for _WIN32
- From: Christopher Faylor <me at cgf dot cx>
- To: dannysmith at users dot sourceforge dot net,binutils <binutils at sources dot redhat dot com>
- Date: Thu, 24 Mar 2005 21:15:52 -0500
- Subject: Re: Patch: binutils/rename.c -Werror fixes for _WIN32
- References: <20050325010008.42199.qmail@web50906.mail.yahoo.com>
On Fri, Mar 25, 2005 at 01:00:08PM +1200, Danny Smith wrote:
>The static function simple_copy() in rename.c is not used by
>__MINGW32__. Nor is the preserve_dates arg of smart_rename.
>
>This fixes -Werror failure.
>
>Tested with i686-pc-mingw32, gcc version 4.1.0 20050321 (experimental)
>
>Changelog
>
>2005-03-24 Danny Smith <dannysmith@users.sourceforge.net>
>
> * rename.c (simple_copy): Remove unneeded prototype. Guard
> definition with !defined (_WIN32) || defined (__CYGWIN__).
> (smart_rename): Mark preserve_dates arg as unused.
> Spell __CYGWIN32__ as __CYGWIN__.
Looks good to me. Thanks for fixing the ancient __CYGWIN32__.
cgf