This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH: Fix MIPS DT_MIPS_UNREFEXTNO
- From: Eric Christopher <echristo at redhat dot com>
- To: "H. J. Lu" <hjl at lucon dot org>
- Cc: binutils at sources dot redhat dot com
- Date: Mon, 21 Mar 2005 18:00:48 -0800
- Subject: Re: PATCH: Fix MIPS DT_MIPS_UNREFEXTNO
- References: <20050316215740.GA20242@lucon.org>
I've not looked at the rest of the patch, but large #if 0 blocks without
commenting isn't OK.
> struct mips_got_info *g;
> +#if 0
> bfd_size_type dynsecsymcount;
>
> /* When we resort, we must tell mips_elf_sort_hash_table what
> @@ -8927,8 +8960,9 @@ _bfd_mips_elf_final_link (bfd *abfd, str
> && !(*bed->elf_backend_omit_section_dynsym) (abfd, info, p))
> ++ dynsecsymcount;
> }
> +#endif
>
-eric