This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: sign extension break sleb128 tests on m68k

From: Nick Clifton <nickc at redhat dot com>
To: Alan Modra <amodra at bigpond dot net dot au>
Cc: binutils at sources dot redhat dot com
Date: Tue, 01 Mar 2005 11:52:54 +0000
Subject: Re: sign extension break sleb128 tests on m68k
References: <20050301042551.GL5299@bubble.modra.org>

Hi Alan,

Does anyone know
why this patch was applied?

Thu Apr 13 14:34:36 1995 Torbjorn Granlund <tege@adder.cygnus.com>

	* config/tc-m68k.c (m68k_init_after_args): Test for m68360.
	(md_parse_option): Likewise.
	(md_show_usage): Mention m68360.
	* config/tc-m68k.h (TARGET_WORD_SIZE): Define.
	(TARGET_ARCH): Define.

	* expr.c (integer_constant): If TARGET_WORD_SIZE is defined,
	sign-extend appropriately.

Presumably it too was concerned with building 32-bit m68k binutils with
a 64-bit bfd, but unfortunately no testcase was added.  So I don't know
whether the hack is still needed.  Failing any good reason being found,
I propose the following:

	* expr.c (integer_constant): Remove TARGET_WORD_SIZE hack.
	* config/tc-m68k.h (TARGET_WORD_SIZE): Delete.

Agreed. I suspect that Torbjorn's patch was an attempt at handling sign-extension in a target specific way when in fact it should have been generic. With the current code handling this sort of thing quite well I doubt very much if his patch is still needed.

Cheers
  Nick

References:
- sign extension break sleb128 tests on m68k
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]