This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH: Test the just built windres/dlltool only
- From: Daniel Jacobowitz <drow at false dot org>
- To: "H. J. Lu" <hjl at lucon dot org>
- Cc: binutils at sources dot redhat dot com
- Date: Fri, 18 Feb 2005 18:01:00 -0500
- Subject: Re: PATCH: Test the just built windres/dlltool only
- References: <20050218225935.GA30688@lucon.org>
On Fri, Feb 18, 2005 at 02:59:35PM -0800, H. J. Lu wrote:
> windres/dlltool may not be built for all platforms. But we are picking
> up them from PATH even if they weren't built at all. This patch
> changes it.
If they are on your $PATH, why aren't we building them? This patch
will disable the tests when testing an installed binutils, I think.
>
>
> H.J.
> ----
> 2005-02-18 H.J. Lu <hongjiu.lu@intel.com>
>
> * config/default.exp: Set WINDRES only if windres is built. Set
> DLLTOOL only if dlltool is built.
>
> --- binutils/testsuite/config/default.exp.win 2004-11-05 14:41:25.000000000 -0800
> +++ binutils/testsuite/config/default.exp 2005-02-18 14:30:17.384437504 -0800
> @@ -62,11 +62,11 @@ if ![info exists READELF] then {
> if ![info exists READELFFLAGS] then {
> set READELFFLAGS ""
> }
> -if ![info exists WINDRES] then {
> - set WINDRES [findfile $base_dir/windres]
> +if {![info exists WINDRES] && [file exists $base_dir/windres]} then {
> + set WINDRES $base_dir/windres
> }
> -if ![info exists DLLTOOL] then {
> - set DLLTOOL [findfile $base_dir/dlltool]
> +if {![info exists DLLTOOL] && [file exists $base_dir/dlltool] } then {
> + set DLLTOOL $base_dir/dlltool
> }
>
> if ![file isdirectory tmpdir] {catch "exec mkdir tmpdir" status}
>
--
Daniel Jacobowitz
CodeSourcery, LLC