This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
[patch] (OB?) Fix for QNX Neutrino core file floating point handler
- From: Kris Warkentin <kewarken at qnx dot com>
- To: binutils at sources dot redhat dot com
- Date: Tue, 21 Dec 2004 17:34:10 -0500
- Subject: [patch] (OB?) Fix for QNX Neutrino core file floating point handler
We weren't generating the floating point register core file sections
properly. Instead of .reg2/tid we were getting .reg2/pid which was
confusing gdb. This patch fixes that. Okay to commit?
cheers,
Kris
ChangeLog:
2004-12-21 Kris Warkentin <kewarken@qnx.com>
* elf.c (elfcore_grok_nto_gregs): Change name to ..._nto_regs.
Add 'base' argument for constructing register sections.
Reformat.
(elfcore_grok_nto_note): Call elfcore_grok_nto_regs for both
gp and fp regs. Reformat.
Index: elf.c
===================================================================
RCS file: /cvs/src/src/bfd/elf.c,v
retrieving revision 1.258
diff -u -r1.258 elf.c
--- elf.c 10 Dec 2004 14:04:55 -0000 1.258
+++ elf.c 21 Dec 2004 22:22:46 -0000
@@ -7382,14 +7382,17 @@
}
static bfd_boolean
-elfcore_grok_nto_gregs (bfd *abfd, Elf_Internal_Note *note, pid_t tid)
+elfcore_grok_nto_regs (bfd *abfd,
+ Elf_Internal_Note *note,
+ pid_t tid,
+ char *base)
{
char buf[100];
char *name;
asection *sect;
- /* Make a ".reg/%d" section. */
- sprintf (buf, ".reg/%d", tid);
+ /* Make a "(base)/%d" section. */
+ sprintf (buf, "%s/%d", base, tid);
name = bfd_alloc (abfd, strlen (buf) + 1);
if (name == NULL)
@@ -7407,7 +7410,7 @@
/* This is the current thread. */
if (elf_tdata (abfd)->core_lwpid == tid)
- return elfcore_maybe_make_sect (abfd, ".reg", sect);
+ return elfcore_maybe_make_sect (abfd, base, sect);
return TRUE;
}
@@ -7427,11 +7430,16 @@
switch (note->type)
{
- case BFD_QNT_CORE_INFO: return elfcore_make_note_pseudosection (abfd, ".qnx_core_info", note);
- case BFD_QNT_CORE_STATUS: return elfcore_grok_nto_status (abfd, note, &tid);
- case BFD_QNT_CORE_GREG: return elfcore_grok_nto_gregs (abfd, note, tid);
- case BFD_QNT_CORE_FPREG: return elfcore_grok_prfpreg (abfd, note);
- default: return TRUE;
+ case BFD_QNT_CORE_INFO:
+ return elfcore_make_note_pseudosection (abfd, ".qnx_core_info", note);
+ case BFD_QNT_CORE_STATUS:
+ return elfcore_grok_nto_status (abfd, note, &tid);
+ case BFD_QNT_CORE_GREG:
+ return elfcore_grok_nto_regs (abfd, note, tid, ".reg");
+ case BFD_QNT_CORE_FPREG:
+ return elfcore_grok_nto_regs (abfd, note, tid, ".reg2");
+ default:
+ return TRUE;
}
}