This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] Fix strings to work with > 2GB files again on 32-bitarches
- From: "Aaron W. LaFramboise" <aaron98wiridge9 at aaronwl dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Sat, 16 Oct 2004 15:21:05 -0500
- Subject: Re: [PATCH] Fix strings to work with > 2GB files again on 32-bitarches
- References: <20041011202028.GQ30497@sunsite.ms.mff.cuni.cz>
Jakub Jelinek wrote:
> 2004-10-11 Jakub Jelinek <jakub@redhat.com>
>
> * strings.c (statbuf): New typedef.
> (file_stat): Define.
> (strings_object_file): Avoid using get_file_size, instead do the
> checks here, using file_stat.
> * configure.in (HAVE_STAT64): New test.
> * configure: Rebuilt.
> * config.in: Rebuilt.
This patch breaks i686-pc-mingw32 because struct stat isn't defined.
Including <sys/stat.h> fixes it.
I have a copyright assignment but no CVS access.
Aaron W. LaFramboise
2004-10-16 Aaron W. LaFramboise <aaron98wiridge9@aaronwl.com>
* strings.c (<sys/stat.h>): Include.
Index: src/binutils/strings.c
===================================================================
RCS file: /cvs/src/src/binutils/strings.c,v
retrieving revision 1.24
diff -c -3 -p -r1.24 strings.c
*** src/binutils/strings.c 13 Oct 2004 14:33:51 -0000 1.24
--- src/binutils/strings.c 16 Oct 2004 20:15:58 -0000
***************
*** 67,72 ****
--- 67,73 ----
#include "bucomm.h"
#include "libiberty.h"
#include "safe-ctype.h"
+ #include <sys/stat.h>
/* Some platforms need to put stdin into binary mode, to read
binary files. */