This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gprof cleanups


Ian Lance Taylor <ian@wasabisystems.com> writes:

> I don't understand the point of this loop either before or after your
> patch.  Doesn't it just duplicate work down by the loop just a few
> lines up?
> 
>   for (sp = &default_excluded_list[0]; *sp; sp++)
>     {
>       sym_id_add (*sp, EXCL_TIME);
>       sym_id_add (*sp, EXCL_GRAPH);
>       sym_id_add (*sp, EXCL_FLAT);
>     }

I finally got around to looking at this and I agree with you.  I'll
submit a proper patch next week that removes the duplicated code.

Ben


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]