This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: mn10300 dynamic relocation clean up: remove dynamic PCREL32


On Jun 29, 2004, Alan Modra <amodra@bigpond.net.au> wrote:

> On Mon, Jun 28, 2004 at 04:55:10AM -0300, Alexandre Oliva wrote:
>> This patch introduces ELF_LINK_HASH_COMMON, set for symbols read in as
>> common symbols.  This bit remains set after the linker turns the

> I don't think you need this.  A symbol that was commonl can be detected
> after lang_common has run using existing flags, like so

>   was_common = ((h->elf_link_hash_flags & ELF_LINK_HASH_DEF_REGULAR) == 0
> 		&& (h->elf_link_hash_flags & ELF_LINK_HASH_DEF_DYNAMIC) == 0
> 		&& h->root.type == bfd_link_hash_defined);

Thanks.  Where is this (supposed to be) documented?

If it's not there, I'll include a fix for the docs in my next revision
of the patch.

-- 
Alexandre Oliva             http://www.ic.unicamp.br/~oliva/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]