This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] x86-64 corrections

From: Andreas Jaeger <aj at suse dot de>
To: "Jan Beulich" <JBeulich at novell dot com>
Cc: <binutils at sources dot redhat dot com>
Date: Fri, 04 Jun 2004 08:00:47 +0200
Subject: Re: [PATCH] x86-64 corrections
References: <s0bf521d.068@emea1-mh.id2.novell.com>

"Jan Beulich" <JBeulich@novell.com> writes:

> 2004-06-03 Jan Beulich <jbeulich@novell.com>
>
> 	* gas/config/tc-i386.c: Adjust immediates to only those
> permissible for
> 	the selected instruction suffix. Don't treat 32-bit addressing
> in
> 	64-bit mode specially except for the width of the used base
> and/or
> 	index registers. Force zero displacement on rip-relative
> addressing
> 	when there is no other displacement.

Your changelogs are broken.

Please name the function you're using.  For example:

	* config/tc-i386.c (optimize_imm): Adjust immediates to only
	those...

Do not add gas or opcodes.  If you touch more than one directory just
prefix them, e.g.:
opcodes:
        * i386-dis.c

Each directory has its own ChangeLog file.

Could you please resend the patch without the broken wrapping?

Thanks,
Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature

References:
- [PATCH] x86-64 corrections
  - From: Jan Beulich

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]