This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Problem with linker with binutils-040414
On Fri, Apr 16, 2004 at 08:11:38AM -0700, H. J. Lu wrote:
> On Fri, Apr 16, 2004 at 12:22:35AM -0400, Daniel Jacobowitz wrote:
> > On Thu, Apr 15, 2004 at 09:48:03AM +0100, Nick Clifton wrote:
> > > bfd/ChangeLog
> > > 2004-04-15 Nick Clifton <nickc@redhat.com>
> > >
> > > * bfd.c (bfd_archive_filename): Catch NULL bfd pointers.
>
> I don't think it is a good idea. Linker should try to avoid core dump
> on bad input. But linker should abort/core dump when there is an
> internal bug. In this particular case, core dump helped uncover/fix the
> linker bug. Otherwise, we might discover this bug much later. I suggest
> we back out this patch or change it to
>
> if (abfd == NULL)
> abort ();
FWIW, I agree with HJ.
--
Alan Modra
IBM OzLabs - Linux Technology Centre