Re: [Patch]: Fw: binutils/cygwin breakage

[Nick Clifton <nickc at redhat dot com>]

Hi Danny, Hi Chris,

> Christopher Faylor <cgf@redhat.com> writes:

>>OK, my bad.   This fixes in my test.  The bug I introduced in my patch was to
>>clear IMAGE_SCN_MEM_WRITE on non-standard sections as well as known ones.
>>
>>This puts it back in the loop through the known sections
>>(where it was originally).
>>
>>Danny
>>
>>2004-02-15  Danny Smith  <daanysmith@users.sourceforge.net>
>>
>>	* peXXigen.c (_bfd_XXi_swap_scnhdr_out): Only clear
>>	IMAGE_SCN_MEM_WRITE on known sections,	 
>
> FWIW, I can confirm that this patch fixes my problems building cygwin with
> the CVS version of binutils.
>
> I do still have minor reservations about unilaterally removing write
> permissions from any well-known text segment since it seems like this
> removes some control from the user.  But your patch doesn't really change
> this behavior.  It just makes it more specific.
>
> So, if there are no reservations from any of the binutils big guns, then
> I'd say this is ok to check in.

No objections from me - please check it in.

Cheers
        Nick