This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH] Adding '.set' pseudo op for ppc - first draft


Since the behaviour I think I'm looking for is to flush and rebuild the
opcode and macro tables when .cpu (as per Alans suggestion) is specified,
why couldn't I just call md_begin() in the pseudo-op handler?

> -----Original Message-----
> From: Jeff Baker
> Sent: June 20, 2003 8:49 AM
> To: 'Daniel Jacobowitz'; Jeff Baker
> Cc: 'binutils@sources.redhat.com'
> Subject: RE: [PATCH] Adding '.set' pseudo op for ppc - first draft
> 
> You're absolutely correct.  I don't know what I did when I tested this the
> first time but now I have it failing, as it should.
> 
> > -----Original Message-----
> > From: Daniel Jacobowitz [mailto:drow@mvista.com]
> > Sent: June 19, 2003 1:54 PM
> > To: Jeff Baker
> > Cc: 'binutils@sources.redhat.com'
> > Subject: Re: [PATCH] Adding '.set' pseudo op for ppc - first draft
> >
> > On Thu, Jun 19, 2003 at 01:30:41PM -0400, Jeff Baker wrote:
> > > This is my first draft at adding the .set pseudo op for ppc.
> > >
> > > gas/ChangeLog:
> > >
> > > 2003-06-19  Jeff Baker jbaker@qnx.com
> > >
> > > 	* config/tc-ppc.c: (ppc_set_cpu_value) New Function.
> > > 	(ppc_set) New Function.
> > > 	(md_parse_option) Uses ppc_set_cpu_value to help parse -m options.
> > >
> >
> > First of all, please use diff -up or -cp.  Diff output is not useful
> > otherwise.
> >
> > Secondly, this must have testcases.
> >
> > Third, have you really tried it?  Please re-read Alan's comment when
> > you first suggested this, about md_begin ().  Then take a good look at
> > that function.  Your code will not work as-is.
> >
> > --
> > Daniel Jacobowitz
> > MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]