This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Memory overrun bug in CVS arm-elf-ld

Hi Alan,

> Nick, I think this is wrong.  h->vtable_entries_size is used here
> (oldbytes) and in other places to determine how many entries are valid.
> Just allocating extra space won't fix the valid entry count.
>
> 	* elflink.h (elf_gc_record_vtentry): Revert last change.  Correct
> 	size calculation from addend.  Round size up.
>
> Note that rounding the size shouldn't be necessary, but I'd rather be
> bomb-proof.

Ok - your fix is much better than mine.  Thanks very much for looking
into this.

Cheers
        Nick
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]