This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [toplevel patch] Remove bogus conditional
- From: Nathanael Nerode <neroden at twcny dot rr dot com>
- To: dj at redhat dot com
- Cc: gcc-patches at gcc dot gnu dot org, binutils at sources dot redhat dot com, gdb-patches at sources dot redhat dot com
- Date: Mon, 9 Jun 2003 21:54:29 -0400
- Subject: Re: [toplevel patch] Remove bogus conditional
>> Nobody noticed. :-)
>
>Unfortunately, that doesn't mean a lot.
>
>> Tested on i686-pc-linux-gnu.
>
>Could you test the case this is designed for, i.e., cross-building a
>native?
Here's the curious thing. The case this is designed for was unchanged
by the typo. (The case where host_canonical != build_canonical. With
the typo, host_canon*ci*al != build_canonical, so it still executes.)
The case which was changed by the typo is the case where
host_canonical=build_canonical (but due to the typo, host_canon*ci*al !=
build_canonical).
In other words, the native and ordinary cross cases. Which I'm guessing
are sufficiently tested, and which is why I'm surprised that nobody
noticed.
At the moment, I can't test a cross-built native properly 'cause I can't
find any which ever worked quite right for me. :-( But that's the
case where I never changed anything here!
--Nathanael