This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Very interesting IA64 gas bug


On Fri, Jun 06, 2003 at 10:25:06PM -0700, Jim Wilson wrote:
> On Fri, 2003-06-06 at 21:47, H. J. Lu wrote:
> > 	* app.c (do_scrub_chars): Add states 14 and 15 to handle
> > 	predicate for ia64.
> 
> Your comment for the new states 14 and 15 doesn't mention that 15
> corresponds to a predicate seen while in state 1.
> 
> Otherwise, this looks OK to me.

I checked in a patch with the updated comments.

> 
> I still have to wonder if maybe ripping out the parser is a better idea,
> but that will have to wait for some other time though.
> 

The one on my list is to fix elf_fake_sections so that type section
type doesn't depend on section name. We have 20 bits to use in
struct sec. Should I give it a shot?

H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]