This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH/RFA] Add --redefine-syms=<filename> option to objcopy
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: Jason Thorpe <thorpej at wasabisystems dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Sun, 1 Jun 2003 15:58:33 -0400
- Subject: Re: [PATCH/RFA] Add --redefine-syms=<filename> option to objcopy
- References: <62EEFB7B-93D2-11D7-A0AD-000A957650EC@wasabisystems.com>
On Sat, May 31, 2003 at 06:43:04PM -0700, Jason Thorpe wrote:
> This is an update of the patch Chris Demetriou posted in this message:
>
> http://sources.redhat.com/ml/binutils/2002-09/msg00505.html
>
> NetBSD has, in fact, been using this patch for a while now in a local
> copy of binutils 2.13. The patch I am posting here is an update, with
> the following changes from Chris's original patch:
>
> * The option is --redefine-syms=<filename> for consistency
> with e.g. --keep-symbols=<filename>.
> * The file may have comments (as is allowed by e.g.
> --keep-symbols=<filename>).
For consistency shouldn't it be --redefine-symbols=<filename>?
> OK for mainline? OK for 2.14 branch?
I don't think this is appropriate for a release branch. Maybe for
2.14.1.
> 2003-05-31 Chris Demetriou <cgd@broadcom.com>
> Jason Thorpe <thorpej@wasabisystems.com>
>
> * objcopy.c (redefine_list_append): Add an argument that
> indicates the context from which this function is being
> called. Change all callers.
> (copy_options): Add a new option, --redefine-syms.
> (copy_usage): Document new option.
> (copy_main): Handle the --redefine-syms option.
> * doc/binutils.text (objcopy): Document new option.
>
> -- Jason R. Thorpe <thorpej@wasabisystems.com>
>
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer