This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] CFI improvements


On Tue, May 20, 2003 at 02:21:18PM +0200, Michal Ludvig wrote:
> -const pseudo_typeS cfi_pseudo_table[] =
> -  {
> -    { "cfi_verbose", dot_cfi, CFI_verbose },
> -    { "cfi_startproc", dot_cfi, CFI_startproc },
> -    { "cfi_endproc", dot_cfi, CFI_endproc },
> -    { "cfi_def_cfa", dot_cfi, CFA_def_cfa },
> -    { "cfi_def_cfa_register", dot_cfi, CFA_def_cfa_register },
> -    { "cfi_def_cfa_offset", dot_cfi, CFA_def_cfa_offset },
> -    { "cfi_adjust_cfa_offset", dot_cfi, CFI_adjust_cfa_offset },
> -    { "cfi_offset", dot_cfi, CFA_offset },
> -    { NULL, NULL, 0 }
> -  };
> +const pseudo_typeS cfi_pseudo_table[] = {
> +  {"cfi_verbose", dot_cfi, CFI_verbose},
> +  {"cfi_startproc", dot_cfi, CFI_startproc},
> +  {"cfi_endproc", dot_cfi, CFI_endproc},
> +  {"cfi_def_cfa", dot_cfi, CFA_def_cfa},
> +  {"cfi_def_cfa_register", dot_cfi, CFA_def_cfa_register},
> +  {"cfi_def_cfa_offset", dot_cfi, CFA_def_cfa_offset},
> +  {"cfi_adjust_cfa_offset", dot_cfi, CFI_adjust_cfa_offset},
> +  {"cfi_offset", dot_cfi, CFA_offset},
> +  {"cfi_register", dot_cfi, CFA_register},
> +  {NULL, NULL, 0}
> +};

Did you mean to undo my formatting fixes?

> -  else if (resolvereg && (is_name_beginner (*input_line_pointer)))
> +  else if (resolvereg && ((is_name_beginner (*input_line_pointer)) ||
> +			  (*input_line_pointer == '%' &&
> +			   is_name_beginner (*(++input_line_pointer)))))

Please fix the formatting errors here.

> +      if (cie_ptr->size == cie_size - 4 &&
> +	  memcmp (cie_ptr->data, cie_buf + 4, cie_ptr->size) == 0)

Again.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]