This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Problems with memory leak fixes
- From: Andrew Cagney <ac131313 at redhat dot com>
- To: David Heine <dlheine at suif dot stanford dot edu>
- Cc: Daniel Jacobowitz <drow at mvista dot com>, binutils at sources dot redhat dot com
- Date: Mon, 31 Mar 2003 19:30:01 -0500
- Subject: Re: Problems with memory leak fixes
- References: <20030401000844.GA30534@nevyn.them.org>
As Andrew already pointed out, the use of concat in dwarf2.c is incorrect.
Worse, the fix is incorrect. The filename is saved in add_line_info, and
can not be free'd in decode_line_info; fixing this leak will take more
careful attention. Reverting the patch fixes twelve failures in the LD
testsuite on i686-pc-linux-gnu.
GDB does not use this code so that doesn't explain which fix broke GDB.
It doesn't get BFD off the hook though either. Reverting the entire BFD
part of the change fixes GDB.
Andrew