Re: Statically identified memory leaks in ld

[DJ Delorie <dj at delorie dot com>]

The libiberty bits need to be sent to gcc-patches at gcc dot gnu dot org dot 
But some quick comments:

The ChangeLog entries can't just say "same" across directories.  You
should also list each function affected, and no space before each
colon.  Each entry should be a complete sentence (start with a
capital, end with a period) although a simple "Likewise." is
sufficient for that case.

This change isn't needed (except for declaring error_status, but it
doesn't need to be initialized:

    int first = 1;
    dyn_string_t old_last_source_name;
    template_arg_list_t arg_list = template_arg_list_new ();
+   status_t error_status = STATUS_OK;
+ 
  
    if (arg_list == NULL)
!     {
!       return STATUS_ALLOCATION_FAILED;
!     }
  
    /* Preserve the most recently demangled source name.  */
    old_last_source_name = dm->last_source_name;

This isn't correct English:

! 	      /* Demangled must be NULL here so it need to be freed. */

Should be "needs", and two spaces after the period.