This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] Fix readelf (was Re: ELF reloc code tidy)
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: binutils at sources dot redhat dot com, Alan Modra <amodra at bigpond dot net dot au>
- Date: Thu, 28 Nov 2002 18:57:35 -0500 (EST)
- Subject: Re: [PATCH] Fix readelf (was Re: ELF reloc code tidy)
On Thu, 28 Nov 2002, Jakub Jelinek wrote:
> On Thu, Nov 28, 2002 at 10:22:09PM +1030, Alan Modra wrote:
> > This probably should be broken into a number of separate patches,
> > but the changes are all related.
> >
> > o Remove all Elf32_Internal_* and Elf64_Internal defines. They just
> > obscure the fact that the 32 and 64 bit variants are identical.
> > A couple of files even used the "wrong" one in some places.
> ...
>
> readelf.c needs corresponding changes too, otherwise it doesn't build.
> Ok to commit?
>
> 2002-11-28 Jakub Jelinek <jakub@redhat.com>
>
> * readelf.c Replace occurrences of Elf32_Internal_* and
> Elf64_Internal_* with Elf_Internal_*.
> (slurp_rel_relocs): Change Elf_Internal_Rel to Elf_Internal_Rela.
> Zero r_addend fields.
> (dump_relocations): Remove relas variable, change Elf_Internal_Rel to
> Elf_Internal_Rela.
Looks pretty *obvious* to me. I guess Alan has the same thing
in his tree, but forgot to commit it. Currently, we have a
broken tree...
brgds, H-P