This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [RFA] Use '=' for assignment in tc-mcore.c, not '=='
- From: Nick Clifton <nickc at redhat dot com>
- To: Klee Dienes <klee at apple dot com>
- Cc: binutils at sources dot redhat dot com
- Date: 21 Nov 2002 11:56:34 +0000
- Subject: Re: [RFA] Use '=' for assignment in tc-mcore.c, not '=='
- References: <DBC0726C-FD2E-11D6-9B40-00039396EEB8@apple.com>
Hi Klee,
> This wasn't me, honest!
:-)
> - /* We would like to compute "hex_float (float_type) * commas"
> - but hex_float is not exported from read.c */
> - float_type == 'f' ? 4 : (float_type == 'd' ? 8 : 12);
> - poolspan += float_type * commas;
> + /* We would like to use the code from hex_float, but it's not
> + exported from read.c. */
> + float_size = 'f' ? 4 : (float_type == 'd' ? 8 : 12);
> + poolspan += float_size * commas;
I think that you meant:
float_size = (float_type == 'f' ? 4 : (float_type == 'd' ? 8 : 12));
Cheers
Nick