This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Constify h8300 support.


On Wed, Nov 13, 2002 at 04:09:20PM -0500, Klee Dienes wrote:
> 2002-11-11  Klee Dienes  <kdienes@apple.com>
> 
> 	* h8300.h (h8_opcode): Remove 'length' field.
> 	(h8_opcodes): Mark as 'const' (both the declaration and
> 	definition).  Modify initializer and initializer macros to no
> 	longer initialize the length field.
> 
> 2002-11-11  Klee Dienes  <kdienes@apple.com>
> 
> 	* h8300-dis.c: Include libiberty.h (for xmalloc).
> 	(struct h8_instruction): New type, used to wrap h8_opcodes with a
> 	length field (computed at run-time).
> 	(h8_instructions): New variable.
> 	(bfd_h8_disassemble_init): Allocate the storage for
> 	h8_instructions.  Fill h8_instructions with pointers to the
> 	appropriate opcode and the correct value for the length field.
> 	(bfd_h8_disassemble): Iterate through h8_instructions instead of
> 	h8_opcodes.

This patch breaks the h8300 assembler.  Please revert or fix.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]