This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
bogon in [PATCH] MIPS gas: irix relocation tweaks
- From: cgd at broadcom dot com
- To: scox at redhat dot com
- Cc: echristo at redhat dot com,binutils at sources dot redhat dot com
- Date: 21 Oct 2002 17:24:57 -0700
- Subject: bogon in [PATCH] MIPS gas: irix relocation tweaks
Stan,
While reading the code for other reasons, I noticed that your patch:
http://sources.redhat.com/ml/binutils/2002-09/msg00119.html
does:
+
+ /* newabi uses R_MIPS_GOT_DISP for local symbols */
+ if (HAVE_NEWABI && BFD_RELOC_MIPS_GOT_LO16)
+ {
+ fixp->fx_r_type = BFD_RELOC_MIPS_GOT_DISP;
+ retval[1] = NULL;
+ }
(very bottom of the patch).
Doesn't look right. 8-)
Not quite sure what you meant here, perhaps:
if (HAVE_NEWABI && fixp->fx_r_type == BFD_RELOC_MIPS_GOT_LO16)
?
(can't really test that change well myself, though.)
cgd