This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: patch for binutils bfd/dwarf2.c.

From: Alan Modra <amodra at bigpond dot net dot au>
To: Nathan Tallent <eraxxon at alumni dot rice dot edu>
Cc: binutils at sources dot redhat dot com, Daniel Jacobowitz <drow at mvista dot com>
Date: Fri, 18 Oct 2002 16:56:56 +0930
Subject: Re: patch for binutils bfd/dwarf2.c.
References: <15790.47193.994000.999884@gargle.gargle.HOWL>

On Thu, Oct 17, 2002 at 09:17:13AM -0400, Nathan Tallent wrote:
> *** dwarf2.c	24 Sep 2002 07:11:16 -0000	1.36
> --- dwarf2.c	17 Oct 2002 13:03:25 -0000
[snip]
> --- 835,903 ----
>     bfd_size_type amt = sizeof (struct line_info);
>     struct line_info* info = (struct line_info*) bfd_alloc (table->abfd, amt);
[snip]
> !       add_line_info(table, address, filename, line, column, end_sequence);
> !       return;
> !     }

I can't say I like the idea of recursing, especially since you'll do
another bfd_alloc.  Please test the attached revision of your patch.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

Attachment: bfd.diff
Description: Text document

References:
- patch for binutils bfd/dwarf2.c.
  - From: Nathan Tallent

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]