This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] MIPS bfd: abi 64 ld -r
- From: Thiemo Seufer <ica2_ts at csv dot ica dot uni-stuttgart dot de>
- To: Stan Cox <scox at redhat dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Tue, 3 Sep 2002 13:20:48 +0200
- Subject: Re: [PATCH] MIPS bfd: abi 64 ld -r
- References: <y0xk7m915pj.fsf@scox.rdu.redhat.com>
Stan Cox wrote:
[snip]
> Index: elf64-mips.c
> ===================================================================
> RCS file: /cvs/uberbaum/./bfd/elf64-mips.c,v
> retrieving revision 1.35
> diff -u -2 -p -r1.35 elf64-mips.c
> --- elf64-mips.c 25 Jul 2002 15:35:14 -0000 1.35
> +++ elf64-mips.c 29 Aug 2002 22:32:54 -0000
> @@ -1370,7 +1372,7 @@ mips_elf64_be_swap_reloca_out (abfd, src
> BFD_ASSERT(src[2].r_addend == 0);
>
> - mirela.r_type2 = ELF64_MIPS_R_TYPE2 (src[1].r_info);
> + mirela.r_type2 = ELF64_MIPS_R_TYPE (src[1].r_info);
> mirela.r_ssym = ELF64_MIPS_R_SSYM (src[1].r_info);
> - mirela.r_type3 = ELF64_MIPS_R_TYPE3 (src[2].r_info);
> + mirela.r_type3 = ELF64_MIPS_R_TYPE (src[2].r_info);
I don't see how _removing_ the TYPE2/TYPE3 handling can improve things.
> mips_elf64_swap_reloca_out (abfd, &mirela,
> Index: elfn32-mips.c
> ===================================================================
> RCS file: /cvs/uberbaum/./bfd/elfn32-mips.c,v
> retrieving revision 1.1
> diff -u -2 -p -r1.1 elfn32-mips.c
> --- elfn32-mips.c 31 Jul 2002 00:32:10 -0000 1.1
> +++ elfn32-mips.c 29 Aug 2002 22:32:54 -0000
> @@ -625,5 +625,5 @@ static reloc_howto_type elf_mips_howto_t
> mips_elf_generic_reloc, /* special_function */
> "R_MIPS_NONE", /* name */
> - false, /* partial_inplace */
> + true, /* partial_inplace */
> 0, /* src_mask */
> 0, /* dst_mask */
It is surely wrong to do partial_inplace with RELA relocations.
Thiemo