Re: PATCH: Check undefined version

["H. J. Lu" <hjl at lucon dot org>]

On Thu, Aug 08, 2002 at 10:56:57AM +0930, Alan Modra wrote:
> On Wed, Aug 07, 2002 at 01:40:43PM -0700, H. J. Lu wrote:
> > I'd like to check in this patch to check symbols with undefine version.
> 
> The idea looks OK to me.
> 
> > +      for (t = verdefs; t != NULL; t = t->next)
> > +	if (t->globals != NULL)
> > +	  for (d = t->globals; d != NULL; d = d->next)
> 
> The "if" here is redundant.
> 
> > +		if (!newh
> 
> Style.  if (newh == NULL
> 
> > +		if (newh
> 
> Again.  if (newh != NULL
> 
> > +	  /* Check if all global versions have a definiton.  */
> > +	  all_defined = true;
> > +	  for (t = verdefs; t != NULL; t = t->next)
> > +	    if (t->globals != NULL)
> > +	      for (d = t->globals; d != NULL; d = d->next)
> 
> Redundant "if"
> 

This is the updated patch I am going to check in.


H.J.

Attachment: binutils-version-def.patch
Description: Text document