This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] pei386: make --enable-auto-import default
- From: Nick Clifton <nickc at cambridge dot redhat dot com>
- To: Charles Wilson <cwilson at ece dot gatech dot edu>
- Cc: binutils at sources dot redhat dot com, cygwin-apps at cygwin dot com
- Date: 31 May 2002 10:50:24 +0100
- Subject: Re: [PATCH] pei386: make --enable-auto-import default
- References: <3CF68E17.6060008@ece.gatech.edu><3CF6B33A.2060405@ece.gatech.edu>
Hi Charles,
Umm - my records do not show a binutils copyright assignment from
you. Without such an assignment we really cannot accept patches to
binutils. :-(
> - link_info.pei386_auto_import = false;
> + link_info.pei386_auto_import = -1; /* 0=disable 1=enable */
I think that you should document what the -1 value means as well.
> - einfo (_("Warning: resolving %s by linking to %s (auto-import)\n"),
> + if (link_info.pei386_auto_import == -1)
> + {
> + info_msg (_("Info: resolving %s by linking to %s (auto-import)\n"),
> undef->root.string, buf);
> + }
You can drop the curly parentheses because there is only one statement
inside the block.
Cheers
Nick