This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix objdump output formatting

From: Alan Modra <amodra at bigpond dot net dot au>
To: Thiemo Seufer <ica2_ts at csv dot ica dot uni-stuttgart dot de>
Cc: Hans-Peter Nilsson <hp at bitrange dot com>, binutils at sources dot redhat dot com
Date: Mon, 20 May 2002 10:01:49 +0930
Subject: Re: [PATCH] Fix objdump output formatting
References: <20020519201409.GH10385@rembrandt.csv.ica.uni-stuttgart.de> <Pine.BSF.4.30.0205191905070.83012-100000@dair.pair.com> <20020519234019.GL10385@rembrandt.csv.ica.uni-stuttgart.de>

> > > Thiemo Seufer wrote:
> > > > 	/binutils/ChangeLog
> > > > 	* objdump.c (dump_headers): Fix output formatting for 32-bit arches
> > > > 	in BFD64 enabled toolchain.

>From a quick look at the patch and code in objdump.c:dump_section_header, 
it appears that you are fixing an output formatting bug for ELF, and
creating a new bug for non-ELF.  See fprintf_vma.  :-(

So, would you please investigate fixing non-ELF fprintf_vma?  If you
can fix that as well, I think we can apply the patch even if it does
break some of the binutils testsuite.  We can fix the testsuite later.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

Follow-Ups:
- Re: [PATCH] Fix objdump output formatting
  - From: Thiemo Seufer

References:
- Re: [PATCH] Fix objdump output formatting
  - From: Thiemo Seufer
- Re: [PATCH] Fix objdump output formatting
  - From: Hans-Peter Nilsson
- Re: [PATCH] Fix objdump output formatting
  - From: Thiemo Seufer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]