This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] windres: (10) The digits A-F are interpreted as 0-5 (BerndHerd)
- From: Gunnar Degnbol <degnbol at danbbs dot dk>
- To: Gunnar Degnbol <degnbol at danbbs dot dk>
- Cc: Hans-Peter Nilsson <hp at bitrange dot com>, binutils at sources dot redhat dot com
- Date: Tue, 19 Mar 2002 23:51:56 +0100
- Subject: Re: [PATCH] windres: (10) The digits A-F are interpreted as 0-5 (BerndHerd)
- References: <Pine.BSF.4.30.0203191601170.29103-100000@dair.pair.com> <3C97B076.9090306@danbbs.dk>
Gunnar Degnbol wrote:
> Hans-Peter Nilsson wrote:
>
>>On Tue, 19 Mar 2002, Gunnar Degnbol wrote:
>>
>>
>>>2002-03-19 Bernd Herd <info@herdsoft.com>
>>>
>>> * rclex.l: "\xhex" encoding in strings corrected
>>
>>
>>>--- binutils/rclex.l Sun Mar 17 14:53:32 2002
>>>+++ binutils.new/rclex.l Sun Mar 17 14:53:37 2002
>>>@@ -394,9 +394,9 @@
>>> if (*t >= '0' && *t <= '9')
>>> ch = (ch << 4) | (*t - '0');
>>> else if (*t >= 'a' && *t <= 'f')
>>>-
>>> ch = (ch << 4) | (*t - 'a');
>>>+
>>> ch = (ch << 4) | (*t - 'a' + 10);
>>> else if (*t >= 'A' && *t <= 'F')
>>>-
>>> ch = (ch << 4) | (*t - 'A');
>>>+
>>> ch = (ch << 4) | (*t - 'A' + 10);
>>> else
>>> break;
>>> ++t;
>>
>>
>>Hey, this (and others of your patches) just seem to add and
>>remove empty lines! Line-wrap? Or is this some new confusing
>>kind of patch format? (I think there was enough confusion with
>>unified and context diffs. ;-)
>>
>>brgds, H-P
>>
>>
>
>
>
> I am really sorry about this.
>
> I use Mozilla. It is also in my outbox. Tabs behave as they should in
> the composer (it is set to plaintext), but are garbled before sending.
>
> I think it is a bug.
>
> Gunnar
>
>
>
It is a bug: http://bugzilla.mozilla.org/show_bug.cgi?id=125569
Has anybody looked at these patches? I will resend them from a sane mailer.
Gunnar