This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix --eh-frame-hdr with DW_EH_PE_absptr in shared libs


On Wed, Feb 20, 2002 at 12:15:34PM +0100, Andreas Jaeger wrote:
> Jakub Jelinek <jakub@redhat.com> writes:
> 
> [...]
> > --- bfd/elf64-x86-64.c.jj	Mon Dec 17 12:29:48 2001
> > +++ bfd/elf64-x86-64.c	Fri Feb 15 17:13:21 2002
> > @@ -1466,21 +1466,21 @@ elf64_x86_64_relocate_section (output_bf
> >  		}
> >  
> >  	      skip = false;
> > +	      relocate = false;
> >  
> >  	      outrel.r_offset =
> >  		_bfd_elf_section_offset (output_bfd, info, input_section,
> >  					 rela->r_offset);
> >  	      if (outrel.r_offset == (bfd_vma) -1)
> >  		skip = true;
> > +	      else if (outrel.r_offset == (bfd_vma) -1)
> > +		skip = true, relocate = true;
> 
> This is wrong.  You check twice for outrel.r_offset == -1, either of
> these are wrong.  I expect you meant a -2 in the second if?

Sure, cut'n'pasto. Will fix.
Thanks.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]