This is the mail archive of the
mailing list for the binutils project.
Re: For 2.12: sh-coff
\On Mon, Feb 18, 2002 at 03:14:29AM -0500, Hans-Peter Nilsson wrote:
> On Sun, 17 Feb 2002, Daniel Jacobowitz wrote:
> > On Sun, Feb 17, 2002 at 08:45:31PM -0800, Ian Lance Taylor wrote:
> > > I would guess that the October 16 patch was not tested for sh-coff.
> Guilty, I guess.
> > > I imagine that the correct fix is to restore the old obj-coff.h
> > > setting of TARGET_FORMAT, but have it test target_big_endian rather
> > > than shl.
> > Since that's the same conclusion I came to, and since a patch to do
> > exactly that fixed most of the testsuite failures, I'll check in
> > that solution in a day or two if no one else pipes up. OK?
> Yes, thank you.
I've committed this. Seems to work just fine.
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
2002-02-18 Daniel Jacobowitz <email@example.com>
* config/obj-coff.h: Check !target_big_endian, not shl, for coff-sh.
RCS file: /cvs/src/src/gas/config/obj-coff.h,v
retrieving revision 1.13
retrieving revision 18.104.22.168
diff -u -p -r1.13 -r22.214.171.124
--- obj-coff.h 2002/01/31 17:33:00 1.13
+++ obj-coff.h 2002/02/18 23:54:47 126.96.36.199
@@ -127,15 +127,10 @@
#define TARGET_FORMAT "pe-shl"
-#if 0 /* FIXME: The "shl" varaible does not appear to exist. What happened to it ? */
#define TARGET_FORMAT \
- (shl \
+ (!target_big_endian \
? (sh_small ? "coff-shl-small" : "coff-shl") \
: (sh_small ? "coff-sh-small" : "coff-sh"))
-#define TARGET_FORMAT \
- (sh_small ? "coff-shl-small" : "coff-shl")