This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] allow easier overriding of ELF_DYNAMIC_INTERPRETER

On Sun, 17 Feb 2002, David O'Brien wrote:

> On Wed, Feb 13, 2002 at 08:35:47PM +0000, Nick Clifton wrote:
> > > If so that still will not allow easy overriding of
> > > ELF_DYNAMIC_INTERPRETER.  How about we just move that macro into its
> > > own header?  It would be very easy to provide an alternate header
> > > via ``configure''.
> >
> > OK - that seems reasonable.
> This is the basic patch I have to do this.  In general, does this look
> OK?  Are there issues with the length of the header file names?

I don't like this.
Why treat overrides of ELF_DYNAMIC_INTERPRETER specially?
(Overriding it at all is questionable, but perhaps a separate
issue.)  And when you actually do need to override stuff, what's
wrong with the #ifndef approach: having a new file, defining
stuff and including the original file, like is used in
elf32-sh-lin.c?  Can someone explain?  Why add some new
mechanism for generalization needlessly and for what seems a
thought-up reason, when there is a mechanism that works and
isn't too ugly?

brgds, H-P

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]