This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: ldlang.c break missing
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: David Heine <dlheine at tensilica dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Wed, 21 Nov 2001 11:42:03 +1030
- Subject: Re: ldlang.c break missing
- References: <3BFABCA3.386D5ED1@tensilica.com>
On Tue, Nov 20, 2001 at 12:27:15PM -0800, David Heine wrote:
> Alan,
> I believe that there is missing "break" statement in the
> map_input_to_output_sections() function
> of ldlang.c. It looks like it was accidentally elided in revision 1.56
> of the ldlang.c file.
Oops, that was one of mine too. There's another one in
lang_gc_sections_1. :-(
> Here's a suggested patch:
>[snip]
Thanks, committing, with a similar fix to lang_gc_sections_1.
2001-11-21 David Heine <dlheine@tensilica.com>
Alan Modra <amodra@bigpond.net.au>
* ldlang.c (map_input_to_output_sections): Replace "break"
accidentally removed with 2001-08-03 change.
(lang_gc_sections_1): Likewise.
--
Alan Modra
Index: ld/ldlang.c
===================================================================
RCS file: /cvs/src/src/ld/ldlang.c,v
retrieving revision 1.67
diff -u -p -r1.67 ldlang.c
--- ldlang.c 2001/11/20 15:31:10 1.67
+++ ldlang.c 2001/11/21 01:07:09
@@ -2056,6 +2056,7 @@ map_input_to_output_sections (s, target,
{
case lang_wild_statement_enum:
wild (&s->wild_statement, target, output_section_statement);
+ break;
case lang_constructors_statement_enum:
map_input_to_output_sections (constructor_list.head,
target,
@@ -4010,6 +4011,7 @@ lang_gc_sections_1 (s)
{
case lang_wild_statement_enum:
lang_gc_wild (&s->wild_statement);
+ break;
case lang_constructors_statement_enum:
lang_gc_sections_1 (constructor_list.head);
break;