This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH: Fix ld -r visibility test for mips
- From: "H . J . Lu" <hjl at lucon dot org>
- To: binutils at sourceware dot cygnus dot com
- Date: Mon, 19 Nov 2001 12:33:41 -0800
- Subject: Re: PATCH: Fix ld -r visibility test for mips
- References: <20011119112514.A8621@lucon.org>
On Mon, Nov 19, 2001 at 11:25:14AM -0800, H . J . Lu wrote:
> I am going to check in this patch. On mips, the type of glibal lables
> default to object. I should specify them as object.
>
>
I checked in the following patch as an obvious fix. Tested on Linux/x86
and Linux/mips.
H.J.
----
2001-11-19 H.J. Lu <hjl@gnu.org>
* ld-elfvsb/define.s: Mark all global lables as object.
* ld-elfvsb/hidden0.d: Match large section number.
* ld-elfvsb/hidden1.d: Likewise.
* ld-elfvsb/internal0.d: Likewise.
* ld-elfvsb/internal1.d: Likewise.
* ld-elfvsb/protected0.d: Likewise.
* ld-elfvsb/protected1.d: Likewise.
* ld-elfvsb/hidden0.d: Change NOTYPE to OBJECT.
* ld-elfvsb/internal0.d: Likewise.
* ld-elfvsb/protected0.d: Likewise.
Index: ld-elfvsb/define.s
===================================================================
RCS file: /work/cvs/gnu/binutils/ld/testsuite/ld-elfvsb/define.s,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 define.s
--- ld-elfvsb/define.s 2001/11/02 17:34:01 1.1.1.1
+++ ld-elfvsb/define.s 2001/11/19 20:24:00
@@ -1,6 +1,10 @@
+ .data
.globl protected
+ .type protected,@object
protected:
.globl hidden
+ .type hidden,@object
hidden:
.globl internal
+ .type internal,@object
internal:
Index: ld-elfvsb/hidden0.d
===================================================================
RCS file: /work/cvs/gnu/binutils/ld/testsuite/ld-elfvsb/hidden0.d,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 hidden0.d
--- ld-elfvsb/hidden0.d 2001/11/02 17:34:01 1.1.1.1
+++ ld-elfvsb/hidden0.d 2001/11/19 20:24:00
@@ -6,5 +6,5 @@
Symbol table '.symtab' contains .* entries:
Num: Value[ ]+Size Type Bind Vis Ndx Name
#...
- .: [0-9a-fA-F]* 0 NOTYPE GLOBAL HIDDEN . hidden
+[ ]*[0-9]+: [0-9a-fA-F]* 0 OBJECT GLOBAL HIDDEN . hidden
#pass
Index: ld-elfvsb/hidden1.d
===================================================================
RCS file: /work/cvs/gnu/binutils/ld/testsuite/ld-elfvsb/hidden1.d,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 hidden1.d
--- ld-elfvsb/hidden1.d 2001/11/02 17:34:01 1.1.1.1
+++ ld-elfvsb/hidden1.d 2001/11/19 20:24:00
@@ -5,5 +5,5 @@
Symbol table '.symtab' contains .* entries:
Num: Value[ ]+Size Type Bind Vis Ndx Name
#...
- .: [0-9a-fA-F]* 0 NOTYPE GLOBAL HIDDEN UND hidden
+[ ]*[0-9]+: [0-9a-fA-F]* 0 NOTYPE GLOBAL HIDDEN UND hidden
#pass
Index: ld-elfvsb/internal0.d
===================================================================
RCS file: /work/cvs/gnu/binutils/ld/testsuite/ld-elfvsb/internal0.d,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 internal0.d
--- ld-elfvsb/internal0.d 2001/11/02 17:34:01 1.1.1.1
+++ ld-elfvsb/internal0.d 2001/11/19 20:24:00
@@ -6,5 +6,5 @@
Symbol table '.symtab' contains .* entries:
Num: Value[ ]+Size Type Bind Vis Ndx Name
#...
- .: [0-9a-fA-F]* 0 NOTYPE GLOBAL INTERNAL . internal
+[ ]*[0-9]+: [0-9a-fA-F]* 0 OBJECT GLOBAL INTERNAL . internal
#pass
Index: ld-elfvsb/internal1.d
===================================================================
RCS file: /work/cvs/gnu/binutils/ld/testsuite/ld-elfvsb/internal1.d,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 internal1.d
--- ld-elfvsb/internal1.d 2001/11/02 17:34:01 1.1.1.1
+++ ld-elfvsb/internal1.d 2001/11/19 20:24:00
@@ -5,5 +5,5 @@
Symbol table '.symtab' contains .* entries:
Num: Value[ ]+Size Type Bind Vis Ndx Name
#...
- .: [0-9a-fA-F]* 0 NOTYPE GLOBAL INTERNAL UND internal
+[ ]*[0-9]+: [0-9a-fA-F]* 0 NOTYPE GLOBAL INTERNAL UND internal
#pass
Index: ld-elfvsb/protected0.d
===================================================================
RCS file: /work/cvs/gnu/binutils/ld/testsuite/ld-elfvsb/protected0.d,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 protected0.d
--- ld-elfvsb/protected0.d 2001/11/02 17:34:01 1.1.1.1
+++ ld-elfvsb/protected0.d 2001/11/19 20:24:00
@@ -6,5 +6,5 @@
Symbol table '.symtab' contains .* entries:
Num: Value[ ]+Size Type Bind Vis Ndx Name
#...
- .: [0-9a-fA-F]* 0 NOTYPE GLOBAL PROTECTED . protected
+[ ]*[0-9]+: [0-9a-fA-F]* 0 OBJECT GLOBAL PROTECTED . protected
#pass
Index: ld-elfvsb/protected1.d
===================================================================
RCS file: /work/cvs/gnu/binutils/ld/testsuite/ld-elfvsb/protected1.d,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 protected1.d
--- ld-elfvsb/protected1.d 2001/11/02 17:34:01 1.1.1.1
+++ ld-elfvsb/protected1.d 2001/11/19 20:24:00
@@ -5,5 +5,5 @@
Symbol table '.symtab' contains .* entries:
Num: Value[ ]+Size Type Bind Vis Ndx Name
#...
- .: [0-9a-fA-F]* 0 NOTYPE GLOBAL PROTECTED UND protected
+[ ]*[0-9]+: [0-9a-fA-F]* 0 NOTYPE GLOBAL PROTECTED UND protected
#pass