This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: i386 gas is broken

From: Alan Modra <amodra at bigpond dot net dot au>
To: Hans-Peter Nilsson <hp at bitrange dot com>
Cc: "H . J . Lu" <hjl at lucon dot org>, binutils at sourceware dot cygnus dot com, Nick Clifton <nickc at cygnus dot com>
Date: Thu, 15 Nov 2001 19:46:21 +1030
Subject: Re: i386 gas is broken
References: <20011115190559.U6922@bubble.sa.bigpond.net.au> <Pine.BSF.4.30.0111150358160.78437-100000@dair.pair.com>

On Thu, Nov 15, 2001 at 04:04:10AM -0500, Hans-Peter Nilsson wrote:
> On Thu, 15 Nov 2001, Alan Modra wrote:
> > 2001-11-12  Nick Clifton  <nickc@cambridge.redhat.com>
> >
> > 	* frags.c (frag_grow): Use frag_make_room() to grow the
> > 	obstack.
> >
> > Reverting this seems to cure all the problems.
> 
> That change looks bogus.  IIUC, frag_make_room will make a new
> chunk when there's no room, and frag_now->fr_fix will be very
> wrong for the "growth".

The trouble is that we keep pointers to the chunk, and within the
chunk.  They all must be updated when realloc'ing.

I'll commit the revert.

Alan

Follow-Ups:
- Re: i386 gas is broken
  - From: Hans-Peter Nilsson

References:
- Re: i386 gas is broken
  - From: Alan Modra
- Re: i386 gas is broken
  - From: Hans-Peter Nilsson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]