Re: [PATCH] Deleting discardable stabs

[Alan Modra <amodra at bigpond dot net dot au>]

On Sun, Nov 11, 2001 at 10:03:40PM -0500, Daniel Jacobowitz wrote:
> +
> +      if (! rcookie->bad_symtab)
> +	if (rcookie->rel->r_offset > offset)
> +	  return false;

Hmm, I guess it's reasonable to assume the relocs will always be sorted.
Assemblers other than gas?

> +      if (rcookie->rel->r_offset != offset)
> +	continue;
> +
> +      rcookie->rel ++;
> +
> +      /* If rcookie->bad_symtab, we should check
> +	 finfo->sections[r_symndx] == NULL by analogy with
> +	 elf_link_input_bfd.  That's not available yet,
> +	 so we might miss some.  */

You do have the syms available, so could check binding.

> +        {
> +          bfd_size_type amt = cookie.locsymcount * sizeof (Elf_External_Sym);
> +          cookie.locsyms = bfd_malloc (amt);

Need to free this somewhere.

> @@ -1319,6 +1321,27 @@ gld${EMULATION_NAME}_place_orphan (file,
>    return true;
>  }
>  
> +boolean elf_bfd_discard_stabs (struct bfd_link_info *);

Wrong prototype.