This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: [RFA:] bfd/elf-strtab.c: make i unsigned long to work around bug in egcs-1.1.2

To: Hans-Peter Nilsson <hp at bitrange dot com>
Subject: Re: [RFA:] bfd/elf-strtab.c: make i unsigned long to work around bug in egcs-1.1.2
From: Alan Modra <amodra at bigpond dot net dot au>
Date: Sun, 11 Nov 2001 22:12:40 +1030
Cc: binutils at sources dot redhat dot com
References: <20011111212716.W6922@bubble.sa.bigpond.net.au> <Pine.BSF.4.30.0111110603110.14927-100000@dair.pair.com>

On Sun, Nov 11, 2001 at 06:10:34AM -0500, Hans-Peter Nilsson wrote:
> 
> Still?

I must have been dreaming.  unsigned long is fine (Hmm, I suppose
size_t is slightly more correct).  Any concerns about overflowing
unsigned long are really paranoid as bfd_malloc will complain if the
allocated array is too big for size_t.

> It shouldn't be called "i"
> anyways, if it stays.

Yes, please rename.  Consider it all pre-approved.  This is obvious
stuff anyway, so much so that I didn't check properly...  Well, that's
the best excuse I can offer. ;)

Alan

Follow-Ups:
- Re: [RFA:] bfd/elf-strtab.c: make i unsigned long to work aroundbug in egcs-1.1.2
  - From: Hans-Peter Nilsson

References:
- Re: [RFA:] bfd/elf-strtab.c: make i unsigned long to work around bug in egcs-1.1.2
  - From: Alan Modra
- Re: [RFA:] bfd/elf-strtab.c: make i unsigned long to work aroundbug in egcs-1.1.2
  - From: Hans-Peter Nilsson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]