This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] Minor fixes for gas (ecoff)
- To: Thiemo Seufer <ica2_ts at csv dot ica dot uni-stuttgart dot de>
- Subject: Re: [PATCH] Minor fixes for gas (ecoff)
- From: amodra at one dot net dot au
- Date: Sun, 29 Apr 2001 20:21:57 +0930
- Cc: binutils at sources dot redhat dot com
- References: <20010413234949.A394@rembrandt.csv.ica.uni-stuttgart.de>
On Fri, Apr 13, 2001 at 11:49:49PM +0200, Thiemo Seufer wrote:
> This patch adds for gas:
> - dependency checking of te-hppa64.h and te-hppalinux64.h
> - variable initialization in itbl-ops.c:itbl_assemble
> - cosmetic fixes to reduce compilation noise for ecoff
Thank you. Would you please resend the patch with some fixes and
ChangeLog entries, and I'll install it.
> @@ -3688,7 +3688,7 @@
> align = backend->debug_align;
> if ((offset & (align - 1)) != 0)
> {
> - unsigned long add;
> + long add;
>
> add = align - (offset & (align - 1));
> if (*bufend - (*buf + offset) < add)
This changes program behaviour. What if *bufend - (*buf + offset) == -1
Maybe that can't happen, but I'd be happier if you leave `add' as
unsigned long, and cast the expression.
> @@ -4446,7 +4446,7 @@
> aux_end = aux_ptr + aux_cnt;
> for (; aux_ptr < aux_end; aux_ptr++)
> {
> - if (*bufend - (char *) aux_out < sizeof (union aux_ext))
> + if (*bufend - (char *) aux_out < (int) sizeof (union aux_ext))
> aux_out = ((union aux_ext *)
> ecoff_add_bytes (buf, bufend,
> (char *) aux_out,
Same sort of potential problem here.
Alan Modra