Re: modification proposal in Binutils

[Nick Clifton <nickc at redhat dot com>]

Hi Luciano,

  Thank you very much for your patch submission to add a --srec-len
switch to objcopy.  Unfortunately there are a couple of problems with
the patch which prevent me from accepting it at this time:

  1.  The FSF does not have a copyright assignment on file from you.
      Without this assignment we cannot accept any work that you
      submit.

      You can get an assignment form by filling out the email template
      at the end of this message and mailing it off

  2.  Your mailer appears to have wrapped your patch at an 80 column
      boundary which makes it rather hard to read.  I appreciate your
      sending the entire, patched, source files as well, but this was
      unnecessary.  Please just attach the patch itself (preferably
      created with "diff -p") and save on mail bandwidth.

  3.  You did not include a ChangeLog entry with your patch.  Ideally
      I like to receive these (as text, *not* a diff) along with the
      patch itself, as it serves as a quick way to observe the patch,
      and it means that I do not have to create one myself.

  4.  Your patch did not follow the GNU coding standards, especially
      for comments, code layout and variable naming conventions.  You
      can find a copy of these standards at:

          http://www.gnu.org/prep/standards_toc.html

  5.  You included a patch to objcopy.1 to document the new command
      line switch, but you did not include a patch to binutils.texi,
      which also documents command line switches.

  Apart from the above problems the patch seems OK.  It does make use
  of a global variable, which is frowned upon by BFD, but it is hard
  to see an alternative way of solving the problem.

Cheers
	Nick

---------------------------------------------------------------------------
Please email the following information to fsf-records@gnu.org, and we
will send you the assignment form that covers the changes you have
already written.  This form covers corrections to those changes, but
it does not cover other further changes to the same program.

Please use your full name as the subject line of the message.


[What is the name of the program or package you're contributing to?]


[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]


[Do you have an employer who might have a basis to claim to own
your changes?  Do you attend a school which might make such a claim?]


[For the copyright registration, what country are you a citizen of?]


[What year were you born?]


[Please write your email address here.]


[Please write your snail address here.]


[Which files have you changed so far, and which new files have you written
so far?]


---------------------------------------------------------------------------