This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [patch] relax16.c: Eliminate an assertion failure
- To: kazu at hxi dot com
- Subject: Re: [patch] relax16.c: Eliminate an assertion failure
- From: Nick Clifton <nickc at redhat dot com>
- Date: Tue, 12 Sep 2000 14:38:34 -0700
- CC: binutils at sources dot redhat dot com
Hi Kazu,
: > Here is an experimental patch which turns off relaxation if multiple
: > symbol definitions are detected. Kazu - does this fix your problem ?
:
: Yes, it does. I was so narrow-minded. I was looking for a place to
: put a global or nearly-global variable to record whether at least one
: multiple definition is seen, and then disable relaxation in ldlang.c.
: Yeah, we could simply cancel disable -relax right in
: multiple_definition.
:
: Your patch seems pretty obvious. Is there anything I should do on my
: side?
Nope.
: Since a multiple definition is a fatal error, I don't think we
: have to worry about outputting a broken executable.
Lets wait a day in case anybody else has a comment to make, and if not
then I will check the patch in.
Cheers
Nick